Fix for https://github.com/Yoast/yoast-acf-analysis/issues/26

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.

https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/

GNU General Public License v3.0

61 stars 20 forks source link

Fix for https://github.com/Yoast/yoast-acf-analysis/issues/26 #38

Closed richardsweeney closed 7 years ago

richardsweeney commented 7 years ago

This fixes #26

richardsweeney commented 7 years ago

@kraftner this is fixed now

kraftner commented 7 years ago

Thanks. This seems to fix the issue - but also breaks it for ACF<5.6 where everything was working fine. So it seems as if this error only appears in ACF>5.6 due to the switch from select2 v3 to v4. I think we should move this back to #26 for now to first discuss if we just say we only support ACF>5.6 or make a fix that works with both versions.

kraftner commented 7 years ago

I am sorry but I'm closing this in favour of #45 which works with all versions of ACF5. Thanks for your work anyway as it pointed me in the right direction!