search

Yoast / yoast-acf-analysis

WordPress plugin that adds the content of all ACF fields to the Yoast SEO score analysis.
https://wordpress.org/plugins/acf-content-analysis-for-yoast-seo/
GNU General Public License v3.0
61 stars 20 forks source link

Test compatibility with ACF 5 (not ACF 5 Pro) #81

Closed kraftner closed 7 years ago

kraftner commented 7 years ago

Today Early Access for ACF 5 (the free version) was announced. We should make sure that it is fully compatible.

kraftner commented 7 years ago

Okay I just gave it a test run and things look great:

:tada: ACF 5 PRO minus PRO fields === ACF 5 FREE :tada:

So basically almost everything is working as expected. We'll only need minor changes for full compatibility. I've opened a PR for the needed changes.

One thing I left out was splitting the dummy fields for the tests for ACF 5 FREE and PRO as the PRO fields just get ignored by ACF anyway.

Generally I am getting the impression that we'll need to make the whole issue of determining the ACF version cleaner just like #80 already started. But we now also need a way to determine FREE vs. PRO in ACF 5. My PR uses ACF_PRO to determine that for now, but maybe acf_get_setting( 'pro' ) would be cleaner. Also I think this needs to be moved to something central as already mentioned in #80.

For everyone also willing to try and not using the internal update mechanism: 5.* is already on .org, tagged but just not merged into trunk. So for those using composer "wpackagist-plugin/advanced-custom-fields": "^5.6.3", should work, otherwise direct downloads: https://downloads.wordpress.org/plugin/advanced-custom-fields.5.6.3.zip