search

Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Reactify the content analysis #193

Closed IreneStr closed 6 years ago

IreneStr commented 7 years ago

This is the overview issue for the Reactification of content analysis (Issue in Roadmap Repo: https://github.com/Yoast/roadmap/issues/4)

Components:

Redux:

Implementation in WP:

Mockup:

seo_analysis_reactified_4_psd___100___layer_2__rgb_8__

Other categories: Errors and Considerations

hedgefield commented 7 years ago

There's been a slight change. This will be step 1 of reactifying the whole Yoast SEO metabox, but in this issue we are just implementing the (collapsible) headers in the analysis results (both for the readability and focus kw tabs).

That means don't work on the stuff around it (the changed headings and the removal of the extra paper that can be seen in the original mockup). @IreneStr can you see that the relevant issues are put on hold/changed? Done :)

For context, see https://github.com/Yoast/yoast-components/issues/195#issuecomment-320925261.

IreneStr commented 7 years ago

@hedgefield Thanks for the update! I've updated all related issues.

On a totally different note: problems - improvements - good doesn't sound like a logical sequence to me. 'Problems' and 'improvements' are nouns (and '4 problems' and '2 improvements' make sense), while 'good' is an adjective (and '2 good' sounds weird). However, I, unfortunately, can't come up with a better name at this moment 😅. Also, improvements (2) sounds to me like the 2 improvements have already been implemented (in contrast to something like needs improvement).

hedgefield commented 7 years ago

@IreneStr I had the exact same problem 😄 It's the fact that Problems and Improvements are actionable, there are plenty of words for them, but when you have done something well, it's just kind of a pat on the back bit of feedback, Good seems like the only choice there... even when altering the intent of that subheading, something like Completed or Done, it's still the same problem. The only kind of words that match are in the area of Successes or Wins or something, but those are very hard to parse, meaning-wise, and sound awkward.

IreneStr commented 7 years ago

@hedgefield Like I wrote, it's hard to find better wording. Successes and Wins don't sound right to me as well. Maybe we can ask Marieke when she's back?

hedgefield commented 7 years ago

That's a good idea.

hedgefield commented 7 years ago

We should remember to also fix this during the reactification https://github.com/Yoast/wordpress-seo/issues/7383

IreneStr commented 7 years ago

@hedgefield Any new thoughts about the header names? Marieke is on vacation again 🙃

hedgefield commented 7 years ago

@IreneStr Discussed with @moorscode and @omarreiss: Problems - Improvements - Good is fine ;)

IreneStr commented 7 years ago

@hedgefield Thanks!

IreneStr commented 7 years ago

@hedgefield Yoast/wordpress-seo#7383 is not a button-issue, but a bug in the marking algorithm.

hedgefield commented 7 years ago

@IreneStr Okay. So what's next? Is it/can it be fixed? Are you posting the details there?

IreneStr commented 7 years ago

Discussed headings with Marieke & Michiel: Errors for the grey bullets when it’s broken, and Considerations for the other grey bullets (focus keyword 10+ words, one or more stop words in the focus keyword)

@hedgefield About the button issue: I've added it to my list of issues to look at. It's not always broken, only in specific cases when the text the marker will mark does not match the original text. Needs a more in-depth investigation.

IreneStr commented 6 years ago

Fixed by Yoast/wordpress-seo#8116