search

Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

AlgoliaSearcher: re-introduce a "Submit Search" button #285

Closed afercia closed 7 years ago

afercia commented 7 years ago

Splitting this out from #243

For accessibility and consistency, consider to re-introduce a "Submit Search" button in the Algolia Search. See https://github.com/Yoast/yoast-components/pull/243#issuecomment-328080925

This was discussed previously, see:

Another important point is the lack of a "submit search" button. We've had an interesting discussion about the Knowledge Base for My Yoast and decided to re-introduce the "submit search" button, see Yoast/my-yoast#689 (comment) related to #198 (Reactify Help Center - KB tab)

afercia commented 7 years ago

Worth noting the mockups on https://github.com/Yoast/yoast-components/issues/198 do have a search submit button.

IreneStr commented 7 years ago

Fixed in #316