Closed afercia closed 6 years ago
This PR can be summarized in the following changelog entry:
dir
<html>
<label>
aria-labelledby
getRtlStyle()
keyup
keydown
onToggleDisabled()
aria-disabled
This PR can be tested by following these steps:
Also, please verify the style adjustments from #682 are OK.
Fixes #681
Acceptance done 👍 I cannot merge this pull because there are some failing tests. I have no clue how to fix these.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
dir
attribute on the<html>
element when switching to RTL, this partially addresses #665<label>
element and usesaria-labelledby
insteadgetRtlStyle()
for RTL languages and adjusts various CSSkeyup
instead ofkeydown
, as that's the native behavioronToggleDisabled()
work when using the Spacebararia-disabled
when the Toggle is disabledTest instructions
This PR can be tested by following these steps:
Also, please verify the style adjustments from #682 are OK.
Fixes #681