Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Don't use trailing spaces in the translatable strings #695

Open afercia opened 6 years ago

afercia commented 6 years ago

For the same reasons explained in https://github.com/Yoast/wordpress-seo/issues/10524#issuecomment-410293372 we shouldn't use trailing spaces in the translatable strings just to add some spacing between strings or on string and a component. See for example:

https://github.com/Yoast/yoast-components/blob/dac4110ea3519488d0ea42e18bfbcc1e79a3b0a3/composites/Plugin/SnippetPreview/components/SnippetPreview.js#L638

and

https://github.com/Yoast/yoast-components/blob/dac4110ea3519488d0ea42e18bfbcc1e79a3b0a3/composites/Plugin/Shared/components/LanguageNotice.js#L21

In 99% of the cases these trailing spaces will be lost during translations and we can't ask translators to take care of trailing spaces.