Fix import in the Snippet Preview demo.

Yoast / yoast-components

Accessible React components by Yoast

GNU General Public License v3.0

21 stars 6 forks source link

Fix import in the Snippet Preview demo. #743

Closed afercia closed 5 years ago

afercia commented 5 years ago

Fixes the snippet preview demo in the standalone app.

To test:

check the standalone app: yarn start and go to localhost:3333
go in the Snippet preview tab
verify there are no errors and the snippet preview / editor work as expected
edit the meta description and verify the progress bar works as expected (max length is 156 characters)

Note: since the date in the meta description demo is hardcoded (Jan 8, 2018 -) you can actually enter only 143 characters before the progress bar turns into orange.

Fixes #740

IreneStr commented 5 years ago

CR 🚧 We don't want to import yoastseo.js stuff from the node_modules anymore. It should use the global instead.

afercia commented 5 years ago

So as far as I see this requires a PR on YoastSEO.js as MetaDescriptionLengthAssessment is not in the global exports.

Nevermind, I see now it's exported as assessments.seo

afercia commented 5 years ago

There are 4 other imports from yoastseo stringProcessing that would need to be updated as well, ~~and I think one of them would need a change in YoastSEO.js~~. As they're out of the scope of this PR, I'll create a separate issue.

IreneStr commented 5 years ago

CR 👍

IreneStr commented 5 years ago

Acceptance 👍