Closed abotteram closed 5 years ago
CR done 👍
I must assume the test instructions haven't been updated and this concern:
We can't rename the earlier id we introduced because of backwards compatibility. The snippet-editor-field-title part comes from a prop, so it can be changed if the developer that uses the component chooses too.
has since then been reconsidered. If so, please let me know and this can be merged 🙂 /Cc @Xyfi
Discussed internally and seems the ID renaming is not a concern.
Summary
This PR can be summarized in the following changelog entry:
fieldId
prop inReplacementVariableEditorStandalone
, that gets added as anid
attribute to the DraftJS editor element with thecontenteditable
attribute.Relevant technical choices:
*
Test instructions
This PR can be tested by following these steps:
yoast-components
is linked towordpress-seo
.snippet-editor-field-title
. This was the existing id on the container wrapper.snippet-editor-field-title-field
. This is the newly added id. Make sure the same div has thecontenteditable
attribute.snippet-editor-field-description
andsnippet-editor-field-title-field
.Fixes #637