Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Added id to draft js editor field #749

Closed abotteram closed 5 years ago

abotteram commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

Fixes #637

Dieterrr commented 5 years ago

CR done 👍

afercia commented 5 years ago

I must assume the test instructions haven't been updated and this concern:

We can't rename the earlier id we introduced because of backwards compatibility. The snippet-editor-field-title part comes from a prop, so it can be changed if the developer that uses the component chooses too.

has since then been reconsidered. If so, please let me know and this can be merged 🙂 /Cc @Xyfi

afercia commented 5 years ago

Discussed internally and seems the ID renaming is not a concern.