Fix Edit Snippet button margin in RTL. - Githubissues

Yoast / yoast-components

Accessible React components by Yoast

GNU General Public License v3.0

21 stars 6 forks source link

Fix Edit Snippet button margin in RTL. #787

Closed afercia closed 5 years ago

afercia commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

Fixes the Edit Snippet button margin with Right To Left languages.

Relevant technical choices:

A very small patch that uses getRtlStyle() to properly set the margin.

Test instructions

go in the standalone app (yarn start and go to http://localhost:3333/ )
in the "Snippet preview" tab, see the Edit Snippet button has a small margin on the left
click "Change language direction" at the top of the page
verify the Edit Snippet button has a right margin

LTR:

screenshot 2018-11-29 at 17 39 36

RTL:

screenshot 2018-11-29 at 17 39 49

Fixes https://github.com/Yoast/wordpress-seo/issues/10610

abotteram commented 5 years ago

CR 👍 Acceptance 👍