Add autocomplete directive to keyphrase fields

Yoast / yoast-components

Accessible React components by Yoast

GNU General Public License v3.0

21 stars 6 forks source link

Add autocomplete directive to keyphrase fields #793

Closed moorscode closed 5 years ago

moorscode commented 5 years ago

Keyphrase and Synonyms input fields

Summary

This PR can be summarized in the following changelog entry:

Removes autocomplete functionality from the Keyphrase and Synonyms input fields.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Inspect the Keyphrase and Synonyms input fields and see the autocomplete="off" being added as HTML attributes
See issue for other test step

Fixes #792

abotteram commented 5 years ago

CR 👍

Updated failing snapshot test.

afercia commented 5 years ago

Build fails for the ESLint max warning limit, looking into it.

afercia commented 5 years ago

Acceptance 👍

Pushed a few changes to disable ESLint react/jsx-no-target-blank in some recently introduced tests that were causing too many warnings because of Using target="_blank" without rel="noopener noreferrer" is a security risk.