Closed Dieterrr closed 5 years ago
CR 👍
Pushed a few changes:
rel={ null }
to omit the rel="noopener noreferrer"
attributes, as these are links that point to yoast.comTo test the RTL styles:
Acceptance 🚧
I suppose that's okay as they both lead to the same place. But whether it's intentional, I don't know.
Last commit:
Acceptance 👍 I've pushed one minor change to prevent the blue box-shadow after clicking in Chrome.
I've pushed one minor change to prevent the blue box-shadow after clicking in Chrome.
Worth noting this change also removes the focus style when using the keyboard: the only indicator now is the underline on the text, which is not great but at least it's something. The persistence of the style "after clicking" is expected, as at that point the link is no more active but it does have focus.
We should try to avoid to change the focus style when the change is not an accessibility improvement 🙂
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Fixes #11906