Closed Dieterrr closed 5 years ago
This PR can be summarized in the following changelog entry:
This PR can be tested by following these steps:
/Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/App.js -- 91:1 warning Missing JSDoc comment require-jsdoc 92:13 warning Missing JSDoc comment require-jsdoc 103:12 warning Missing JSDoc comment require-jsdoc 112:10 warning Missing JSDoc comment require-jsdoc 118:14 warning Missing JSDoc comment require-jsdoc 135:9 warning Missing JSDoc comment require-jsdoc 176:20 warning Missing JSDoc comment require-jsdoc 183:8 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/AppWrapper.js 11:20 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/KeywordExample.js 23:16 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/KeywordSuggestionWrapper.js 5:22 warning Missing JSDoc comment require-jsdoc 15:35 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/SnippetEditorExample.js 49:16 warning Missing JSDoc comment require-jsdoc 84:11 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/SvgIconsWrapper.js 45:19 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/app/WizardWrapper.js 7:1 warning Missing JSDoc comment require-jsdoc 11:23 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/AlgoliaSearch/AlgoliaSearcher.js 26:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/AlgoliaSearch/ArticleContent.js 20:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/basic/ErrorBoundary.js 20:16 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/basic/Loader.js 4:16 warning Missing JSDoc comment require-jsdoc 69:2 warning propType "className" is not required, but has no corresponding defaultProp declaration react/require-default-props /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/OnboardingWizard/components/Choice.js 28:19 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/OnboardingWizard/tests/wizardTest.js 19:21 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/CornerstoneContent/components/CornerstoneToggle.js 12:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/DashboardWidget/components/WordpressFeed.js 72:31 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/ScoreAssessments.js 40:25 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/SectionTitle.js 31:29 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/StackedProgressBar.js 24:28 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/Toggle.js 57:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/UpsellButton.js 117:29 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/components/YoastModal.js 26:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/Shared/tests/CollapsibleTest.js 99:20 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/__mocks__/ReplacementVariableEditorStandalone.js 6:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/Mention.js 20:24 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/ReplacementVariableEditor.js 20:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/SettingsSnippetEditor.js 13:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/SettingsSnippetEditorFields.js 18:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/Shared.js 9:27 warning Missing JSDoc comment require-jsdoc 15:26 warning Missing JSDoc comment require-jsdoc 83:32 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/SnippetEditor.js 102:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/components/SnippetEditorFields.js 41:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/tests/serializationTest.js 192:21 warning Missing JSDoc comment require-jsdoc 217:21 warning Missing JSDoc comment require-jsdoc 251:21 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetEditor/tests/SnippetEditorTest.js 29:32 warning Missing JSDoc comment require-jsdoc 37:23 warning Missing JSDoc comment require-jsdoc 42:25 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetPreview/components/HelpTextWrapper.js 65:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetPreview/components/SnippetPreview.js 252:16 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/composites/Plugin/SnippetPreview/tests/SnippetPreviewTest.js 17:32 warning Missing JSDoc comment require-jsdoc 25:23 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/render.js 9:1 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/utils/i18n.js 68:2 warning Missing JSDoc comment require-jsdoc 69:14 warning Missing JSDoc comment require-jsdoc 73:9 warning Missing JSDoc comment require-jsdoc /Users/dieterschalk/Code/VVV/www/wordpress-default/public_html/wp-content/plugins/yoast-components/utils/intlProvider.js 5:40 warning Missing JSDoc comment require-jsdoc
Run grunt check to check.
grunt check
2nd CR 👍
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Run
grunt check
to check.