Babelify YoastSEO.js in the standalone - Githubissues

Yoast / yoast-components

Accessible React components by Yoast

GNU General Public License v3.0

21 stars 6 forks source link

Babelify YoastSEO.js in the standalone #820

Closed igorschoester closed 5 years ago

igorschoester commented 5 years ago

IE11 does not support destructuring of assignments (or any destructuring https://kangax.github.io/compat-table/es6/#ie11). Use Babel to transpile this to IE11 understandable code.

Summary

This PR can be summarized in the following changelog entry:

[non-user-facing] Fixes the standalone in IE11.

Relevant technical choices:

Adds an exception for node_modules/yoastseo in the babel exclusion of the webpack config.

Test instructions

This PR can be tested by following these steps:

use IE11
on yoast-components, run yarn to make sure everything is updated
run yarn start and go to the standalone demos on http://localhost:3333
open the IE11 console (press F12)
note that the IE11 console needs to be open, this is a pre-existing issue: without opening the console you won't see anything

Ensure you no longer get the following:

even with the console open, you will get a blank page
see a couple of cryptic JS errors in the console: one of them seems related to the relevant words

UI changes

[ ] ~This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.~

Fixes https://github.com/Yoast/YoastSEO.js/issues/2086

manuelaugustin commented 5 years ago

CR & acceptance done 👍