Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Update to styled-components v4 #825

Closed abotteram closed 5 years ago

abotteram commented 5 years ago

Summary

This PR can be summarized in the following changelog entry:

Relevant technical choices:

*

Test instructions

This PR can be tested by following these steps:

UI changes

Fixes #

bintzandt commented 5 years ago

@Xyfi I get a lot of merge conflicts when trying to move this issue to the https://github.com/Yoast/javascript monorepo.

Could you see if you can fix them? I had a look at them but I lack context from this specific issue.

You can run the following command from the root of the monorepo in order to transfer the branch: ./transfer-branch.sh yoast-components develop update-styled-components-4 This will give some merge conflicts that can be resolved. After resolving them you can push the branch to the repo by executing: git push --set-upstream origin update-styled-components-4

Please ping me when this is resolved and the branch has been created on the monorepo.