Closed afercia closed 5 years ago
In MyYoast, see https://github.com/Yoast/my-yoast/pull/2279, we've made the Link component able to automatically handle the rel attribute.
Link
rel
As per https://github.com/Yoast/wordpress-seo/issues/4605#issuecomment-425409923, the desired behavior is:
noopener
In WordPress, noreferrer is redundant, especially after https://core.trac.wordpress.org/changeset/41741 see https://core.trac.wordpress.org/ticket/42036
noreferrer
Currently, each time we don't want a rel attribute rendered, we're explicitly passing a rel={ null }. This is prone to human errors and can be easily forgotten. makeOutboundLink should handle this automatically.
rel={ null }
makeOutboundLink
12262 (Free) still needs action, 2259 (Premium) CR Done 👍 , 9 (Monorepo) CR Done 👍
Moving to code review done as the previous PR was already CR'ed.
In MyYoast, see https://github.com/Yoast/my-yoast/pull/2279, we've made the
Link
component able to automatically handle therel
attribute.As per https://github.com/Yoast/wordpress-seo/issues/4605#issuecomment-425409923, the desired behavior is:
noopener
for all the non-yoast.com external linksIn WordPress,
noreferrer
is redundant, especially after https://core.trac.wordpress.org/changeset/41741 see https://core.trac.wordpress.org/ticket/42036Currently, each time we don't want a
rel
attribute rendered, we're explicitly passing arel={ null }
. This is prone to human errors and can be easily forgotten.makeOutboundLink
should handle this automatically.