Closed IreneStr closed 5 years ago
CR done
Acceptance 👍
Noticed in Firefox these buttons-links have no focus style. They rely on the browsers native outline, and in Firefox the outline doesn't work when unsetting the borders. Will create a separate issue.
Tested "Previous" and "Next" buttons in Conf Wizard in IE11 and Edge - looks good 👍!
Summary
This PR can be summarized in the following changelog entry:
previous
andnext
buttons in the onboarding wizard look like links.Relevant technical choices:
**/coverage/**
to.eslintignore
to make sure that files in this folder are ignored when runninggrunt eslint
.Test instructions
This PR can be tested by following these steps:
trunk
: go to Yoast SEO > General and open the configuration wizard. See a pink and whitenext
andprevious
button on the right-hand side.trunk
of wordpress-seo (in yoast-components:yarn link
, in wordpress-seo:yarn link yoast-components
).yarn install && grunt build
, in wordpress-seo:composer install && yarn install && grunt build && yarn start
)next
andprevious
buttons (styled as links) aligned to the left and right. Compare what you see to the design in the issue (but seeRelevant technical choices
above).yarn start
in yoast-components and go to localhost:3333 in your browser. Click theWizard
button, and see the changed navigation there as well.UI changes
Fixes Yoast/wordpress-seo/issues/12276