Yoast / yoast-components

Accessible React components by Yoast
GNU General Public License v3.0
21 stars 6 forks source link

Input validation: Configuration Wizard #843

Closed afercia closed 5 years ago

afercia commented 5 years ago

See https://github.com/Yoast/wordpress-seo/issues/12173.

All the Configuration Wizard inputs that require a specific format should use an input validation mechanism and provide proper feedback to users.

For the Social Accounts URL fields, there's a PR exploring browsers constraint validation, see #827.

Other fields that need some input validation mechanism:

Google authorization code:

screenshot 2019-03-06 at 14 02 21

Newsletter email:

Good news:

52333373-61747e80-29fd-11e9-82d1-0a36b89127be screenshot 2019-03-06 at 14 02 55 screenshot 2019-03-06 at 14 15 27

Not translated messages:

screenshot 2019-03-06 at 14 35 16
jdevalk commented 5 years ago

I see three different issues here:

afercia commented 5 years ago

Closing in favor of https://github.com/Yoast/javascript/issues/137 and https://github.com/Yoast/javascript/issues/138