search

Yoast / yoastcs

Yoast coding standards
MIT License
21 stars 3 forks source link

YoastCS: add extra WP related rules #365

Closed jrfnl closed 9 months ago

jrfnl commented 9 months ago

Composer: add Automattic VIP sniffs requirement

YoastCS rules: add a few VIP sniffs to prevent some typical WP compat bugs

There is one known bug in the WordPressVIPMinimum.Hooks.AlwaysReturnInFilter sniff related to a redirect being done from within the filter. This has been reported upstream Automattic/VIP-Coding-Standards#719.

Related to #303

Fixes #229

Impact on Yoast packages:

Plugin/Tool Errors/Warnings
PHPUnit Polyfills --
WP Test Utils --
YoastCS --
WHIP --
Yoast Test Helper --
Duplicate Post --
Yst ACF --
Yst WooCommerce --
Yst News --
Yst Local 2 (proper escaping)
Yst Video --
Yst Premium 1 (false positive/reported bug)
Yst Free 2 (1 false positive/reported bug)

Note: these rules were previously already "silently" enforced via clean-up sweeps.

coveralls commented 9 months ago

Coverage Status

coverage: 99.411%. remained the same when pulling 44c961f3a70d3d08bc7ae4adf670ddcaf508716b on JRF/yoastcs-wp-related-rules into f209bcab99c145e86141ffc653639758c6c05d3e on develop.