search

YoavHaifa / WorkersRightsComputer

Half ready version
1 stars 0 forks source link

Appendix table exceeds page width #25

Open eyalroz opened 4 years ago

eyalroz commented 4 years ago

The appendix the calculator generates includes a one-row table (well, one header row and one values row). Occasionally/often/under certain conditions, this table does not fit the page width or even in the margins, and simply exceeds the page dimensions. It should be scaled so as to necessarily fit on the printed page.

Note: This might have something to do with whether you open the file in a browser or a document editor like MS-Word.

YoavHaifa commented 3 years ago

This might be solved by splitting the table to two tables: showing pension and severance separately. To be checked in next version (1.1.0)

eyalroz commented 3 years ago

The thing is, you create the HTML table with width: 50% in its style attribute. On the HTML level this should be sufficient; and yet when we open the file in word, something allows it to overflow beyond the page width. Now, it's true we might just avoid this problem manifesting if the table is split in two, but I would try to investigate why exactly this happens - whether the table gets split or it doesn't.

As for the splitting - I have no opinion about it. I'd have to look at it on paper to see how it feels. Anyway, whatever Iris thinks is best.