search

YoavHaifa / WorkersRightsComputer

Half ready version
1 stars 0 forks source link

Program presumes to succeed in loading invalid XML files #47

Open eyalroz opened 1 year ago

eyalroz commented 1 year ago

If you try to load an empty XML file, or, say, the app's config.xml file - the program does not indicate any problem, and sets its fields somehow (possibly to default values?) - that does not seem reasonable. The program should distinguish valid saved-files from invalid ones, and indicate when it encounters an invalid file. It may even be a good idea not to change any field values when an invalid save file is encountered.

YoavHaifa commented 1 year ago

The Saver/Loader changed to recognize empty file and some files that are not WRC save files. An error is displayed to the user with the specific condition. I still erase old values in the app to prevent confusion.

eyalroz commented 1 year ago

@YoavHaifa : Assuming this changed in a commit, you could have had the commit message say this, as well as "fixes #47" in the first line - then you would not have had to duplicate the effort of reporting the fix here on the bug page.

Here's an example of how this works in a project of mine:

eyalroz commented 1 year ago

So, is this bug resolved on the master branch?

YoavHaifa commented 1 year ago

Hi Eyal, Sorry, but I have no idea :) Best, Yoav

On Sun, Apr 16, 2023 at 5:41 PM Eyal Rozenberg @.***> wrote:

So, is this bug resolved on the master branch?

— Reply to this email directly, view it on GitHub https://github.com/YoavHaifa/WorkersRightsComputer/issues/47#issuecomment-1510402661, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG5YLNUDDBF7REGX4XVHKIDXBQAIPANCNFSM6AAAAAATJ43V3E . You are receiving this because you were mentioned.Message ID: @.***>