search

Yoctol / bottender

⚡️ A framework for building conversational user interfaces.
https://bottender.js.org
MIT License
4.22k stars 335 forks source link

feat(express): support url behind proxies #816

Closed chentsulin closed 4 years ago

chentsulin commented 4 years ago

815

This is a quick workaround for supporting express behind proxies, but eventually we should add proxy support in Bottender v1.5 to apply X-Forwarded-Host and X-Forwarded-Proto conditionally instead of replying on express. After that, we can gracefully support it even in koa, restify, ...etc.

codecov-commenter commented 4 years ago

Codecov Report

Merging #816 into master will decrease coverage by 0.04%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   83.27%   83.23%   -0.05%     
==========================================
  Files         108      108              
  Lines        5644     5647       +3     
  Branches     1365     1367       +2     
==========================================
  Hits         4700     4700              
- Misses        921      924       +3     
  Partials       23       23
Impacted Files Coverage Δ
packages/bottender/src/server/Server.ts 8.69% <0.00%> (-0.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce0f13c...b82db89. Read the comment docs.