search

Yoctol / bottender

⚡️ A framework for building conversational user interfaces.
https://bottender.js.org
MIT License
4.2k stars 333 forks source link

removed(*Bot): remove *Bot class #934

Closed chentsulin closed 2 years ago

chentsulin commented 2 years ago

*Bot classes are not good abstractions. Telegram Long Polling and Slack RTM should be added back later.

codecov-commenter commented 2 years ago

Codecov Report

Merging #934 (dcc2e48) into develop (46e6d73) will decrease coverage by 0.43%. The diff coverage is 25.00%.

:exclamation: Current head dcc2e48 differs from pull request most recent head 44d90f3. Consider uploading reports for the commit 44d90f3 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #934      +/-   ##
===========================================
- Coverage    85.20%   84.77%   -0.44%     
===========================================
  Files          122      116       -6     
  Lines         6146     6062      -84     
  Branches      1603     1598       -5     
===========================================
- Hits          5237     5139      -98     
- Misses         905      917      +12     
- Partials         4        6       +2
Impacted Files Coverage Δ
packages/bottender/src/index.ts 100.00% <ø> (ø)
packages/bottender/src/shared/getClient.ts 52.94% <25.00%> (+0.30%) :arrow_up:
packages/bottender/src/bot/Bot.ts 88.81% <0.00%> (-9.22%) :arrow_down:
...ckages/bottender/src/telegram/TelegramConnector.ts 95.91% <0.00%> (-1.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 675dd78...44d90f3. Read the comment docs.