Add support to click events

Yoctol / react-d3-cloud

A word cloud react component built with d3-cloud.

https://yoctol.github.io/react-d3-cloud

MIT License

142 stars 47 forks source link

Closed bailon closed 6 years ago

bailon commented 6 years ago

Based on the solution provided by @Benvorth and the feedback from @stegben. I hope this time it will be accepted!

bailon commented 6 years ago

Updated tests and README.

stegben commented 6 years ago

Why closed?

stegben commented 6 years ago

LGTM, merge after your feedback

tw0517tw commented 6 years ago

Will it be better if we name that prop onWordClick? clickEvent sounds like a variable, not a function.

bailon commented 6 years ago

No idea why I closed, still learning the process here, sorry!

Should I update the prop name as proposed by @tw0517tw ?

bailon commented 6 years ago

Is there anything missing from my side that I can help with? Thanks!

stegben commented 6 years ago

Sorry for my late response, it looks good and I'll upload a new release. Thanks a lot!