search

Yoctol / strpipe

text preprocessing pipeline
Other
5 stars 0 forks source link

rename TokenToIndexWithUnk to TokenToIndex #53

Closed stegben closed 5 years ago

stegben commented 5 years ago

Fulfill the naming convention (file name and the main module name should be consistent).

SoluMilken commented 5 years ago

We should not change the function name, because there should be one function called token2index_with_hash.

stegben commented 5 years ago

I would prefer hash_token

SoluMilken commented 5 years ago

HashTokentoIndex ???