YoengKokLeong / pe

0 stars 0 forks source link

Error in settled #6

Open YoengKokLeong opened 2 months ago

YoengKokLeong commented 2 months ago

Screenshot 2024-04-19 at 4.56.21 PM.png

calling 'settle' on a member who owns money results in a transaction format which does not explain the error very clearly Screenshot 2024-04-19 at 5.02.27 PM.png

when mahesh2 and yijie has a transaction history of a very huge number, settled resolves back to 0, however Nigel still owns mahesh2 $1000 and the value does not tally up anymore

Screenshot 2024-04-19 at 5.03.37 PM.png

soc-pe-bot commented 2 months ago

Team's Response

Duplicate of #2044 as it concerns how we handle large inputs and our lack of measures to prevent large values from being input.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect owed amount shown when adding large numbered transactions

image.png

This may be a problem if I am given an incorrect amount to take note of as debt for managing large debts.


[original: nus-cs2113-AY2324S2/pe-interim#2439] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We accept this bug, but think it should be of a severity of low as it is unlikely to affect normal operations since the application is designed for transactions within groups and transactions within friends is unlikely to reach the amounts as tested.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]