search

Yogui79 / IntexPureSpa

Intex® PureSpa remote control for Home Automation
MIT License
61 stars 15 forks source link

Programm Bug? #41

Open HansEhls opened 2 years ago

HansEhls commented 2 years ago

Hello,

I see in the spa programm following 816 - 821

// setpoint is done if ( TargetSetpointTemperarue == ActualSetpointTemperarue || (TargetSetpointTemperarue > 40 && !FarenheitCelsius) || (TargetSetpointTemperarue < 10 && !FarenheitCelsius) || (TargetSetpointTemperarue > 50 && FarenheitCelsius) || (TargetSetpointTemperarue < 104 && FarenheitCelsius) ){ ChangeTargetSetpointTemperarue = false; return;

Should not the 2 lines for farenheit be turned around?

like: || (TargetSetpointTemperarue < 50 && FarenheitCelsius) || (TargetSetpointTemperarue > 104 && FarenheitCelsius)

Otherwise the program would not secure that values outside of 50 and 104 are not accepted

BR Hans

Yogui79 commented 2 years ago

Hi, of course you are right