Open kirxkirx opened 3 years ago
On a different note, you may be curious to see the comparison of z2n
with the implementation in my code and the "standard" tool XRONOS/powspec
. The slight difference with XRONOS/powspec
is because it computes a different thing: rather than follow the Discrete Fourier Transform definition directly (Deeming, 1975) as patpc
and z2n-periodogram
do, powspec
produces a binned `lightcurve'' with a regular sampling where most of the measurements are 0 (no photons arrived), some measurements are equal to 1 (one photon arrived) and maybe some bins have more than one photon. Then
powspec` runs an FFT on this lightcurve. Overall, this procedure is similar, but not the same as computing the Discrete Fourier Transform over the list of photon arrival times.
So in summary, our codes produce similar results and arguably they are doing the right thing! :)
Thanks for the nice code!
One small problem I've encountered: when I left the
Maximum frequency (Hz)
to the default value of 0 no computation has been done. The reason is kind of obvious, but at the same time it's confusing as when one runs the new code, the intuitions suggest to try it with the default values first. Maybe you can change the default value ofMaximum frequency (Hz)
to something like 1 or 0.1? Here is how the interaction with the program looked like:I know I shouldn't combine multiple things in one Issue, but this one is so small that I'll do it anyway: I suggest to put a hyperlink to the Buccheri et al. (1983) paper in README.md The link is https://ui.adsabs.harvard.edu/abs/1983A%26A...128..245B/abstract