Refactor, add doc and tests, improve installation, add an option to remove some tweet's trailing URL

YoloSwagTeam / t2m

Twitter to Mastodon timeline forwarding tool

GNU General Public License v3.0

76 stars 15 forks source link

Refactor, add doc and tests, improve installation, add an option to remove some tweet's trailing URL #13

Closed fcayre closed 6 years ago

fcayre commented 7 years ago

follow standard coding style
refactor to improve readabilty and reduce code duplication
add docstrings
make t2m pip installable ("pip install ." or "python setup.py install" on a git clone, in a virtualenv or not)
add unit tests and a tox configuration to test on python 2.7 and 3.5
add a "-s" option to strip the trailing URL that Twitter API adds to the end of some tweets (see https://twittercommunity.com/t/api-returns-url-to-twitters-status-update-at-the-end-of-the-text/50424)

fcayre commented 7 years ago

I also added a travis-ci configuration, which status on my branch is:

Psycojoker commented 7 years ago

Hello,

Thanks a lot for your work :) As you might have guessed, I'm sadly quite busy right now so I don't know when I'll have the time to correctly review that (and this is not a small PR), sorry for that :confused:

fcayre commented 6 years ago

No hurry, take the time you need!

fcayre commented 6 years ago

Hi @Psycojoker, will you any time to review my PR in the coming days/ weeks?

Psycojoker commented 6 years ago

Finally to the time to merge it, sorry for the delay :sweat_smile:

And thanks a lot for your contribution, this will help release t2m on pypi :)

Psycojoker commented 6 years ago

Btw, if you are interesting in helping maintaining this tool, it's now part of YoloSwagTeam if this is somehting in which you would find your place :)