YoloWingPixie / lsobot

A log scrapper for DCS World that checks for new carrier landing grades made by humans and sends them to Discord.
MIT License
11 stars 8 forks source link

[Regrading] Merge Comments of the Same State in Different Groove Phases Together #11

Open YoloWingPixie opened 3 years ago

YoloWingPixie commented 3 years ago

Describe the bug Currently a chain of comments like _LULIM_ (LULIC) LULAR will be written as such which when sprinkled into the rest of a grade may make "reading the story" of the landing difficult.

Expected behavior Using the above example, this could be written simply as LULIM-AR. Similarly LURX LURIM LURIC LURAR could be written as LURAW

Additional Info When evaluating the severity of the grades perhaps a point system could be assigned where a minor deviation ( (LURX) ) is worth 1 point, a normal deviation is worth 2 points (LURX), and a major deviation is worth 3 points (_LURX_). The points for each phase that get added to the merged comment are averaged and the merged comment made minor if the average is between 1 and 1.5, normal if between 1.5 and 2.5, and major if 2.5 to 3.

e.g. (LURX) 1pt LURIM 2pts _LURIC_ 3pts = 5pts/3 = 2 Normal.

But there would need to also be a bias towards IC and AR calls since these are inherently less safe deviations.