search

Yomguithereal / baobab

JavaScript & TypeScript persistent and optionally immutable data tree with cursors.
MIT License
3.15k stars 115 forks source link

chore: Updated Babel Dependencies #492

Closed anthony-redFox closed 6 years ago

Yomguithereal commented 6 years ago

Hello @anthony-redFox. Why did you drop the loose transpilation? It was there for bundle size & performance.

anthony-redFox commented 6 years ago

@Yomguithereal you right, I missed "loose" option. fixed

Yomguithereal commented 6 years ago

And I don't remember correctly but won't the env preset compile for node's version hence making the build unusable on currently supported browsers?

anthony-redFox commented 6 years ago

By default uses babel-preset-es2015, babel-preset-es2016, and babel-preset-es2017 together https://babeljs.io/docs/plugins/preset-env/

It is support node and browsers and currently we also transpile code to ES5 version.

anthony-redFox commented 6 years ago

@Yomguithereal Env just encapsulate babel-preset-es2015, babel-preset-es2016, and babel-preset-es2017 depend of version node or browsers. Which browser version are you care we will not support?

Yomguithereal commented 6 years ago

ES2015 should be the only thing to transpile because I don't use later features. Built version should support at least IE9 if I remember correctly.

anthony-redFox commented 6 years ago

@Yomguithereal done. Replaced on babel-preset-es2015 package.

Yomguithereal commented 6 years ago

Thanks @anthony-redFox. Merging now.