Security Fix for Prototype Pollution - huntr.dev

@arjunshibu (https://huntr.dev/users/arjunshibu) has fixed a potential Prototype Pollution vulnerability in your repository 🔨. For more information, visit our website (https://huntr.dev/) or click the bounty URL below...

User Comments:

:bar_chart: Metadata *

baobab is vulnerable to Prototype Pollution.

Bounty URL: https://www.huntr.dev/bounties/1-npm-baobab

:gear: Description *

Prototype Pollution refers to the ability to inject properties into existing JavaScript language construct prototypes, such as objects. JavaScript allows all Object attributes to be altered, including their magical attributes such as __proto__, constructor and prototype. An attacker manipulates these attributes to overwrite, or pollute, a JavaScript application object prototype of the base object by injecting other values. Properties on the Object.prototype are then inherited by all the JavaScript objects through the prototype chain.

:computer: Technical Description *

Fix implemented by not allowing to modify object prototype.

:bug: Proof of Concept (PoC) *

Create the following PoC file:


// poc.js
const Baobab = require('baobab');

console.log(Before: ${{}.polluted}) tree = new Baobab() tree.deepMerge(JSON.parse('{"proto": {"polluted": true}}')) console.log(After: ${{}.polluted})

2. Execute the following commands in terminal:
```bash
npm i baobab # Install affected module
node poc.js #  Run the PoC

Check the Output:
```
Before : undefined
After : true
```

:fire: Proof of Fix (PoF) *

I've added unit tests for Prototype Pollution

+1 User Acceptance Testing (UAT)

I've executed unit tests.
After fix the functionality is unaffected.

Yomguithereal / baobab