Closed d4rky-pl closed 6 years ago
Can you just solve the conflicts arising from merging your other PR please, so I can merge? I will probably publish a release to npm afterwise.
Sure, I was considering waiting for #80 to merge before sending this but decided it makes sense to just push it. RIght now I'm at work so I'm afraid this will have to wait few more hours though.
Do you think all these changes merit a 0.3.0 release or only 0.2.2 ?
0.3.0
I guess since there is a new feature.
All right, master have been merged in and I bumped the version to 0.3.0. Tested the library working both with run.js demo
and with an example app
I'll merge then. Do you need a swift npm release?
@Yomguithereal not really, the project I was planning to do is not going to happen after all so I mostly did all this refactoring for fun :)
When I run the demo I get this:
WARNING: the `ws` package must be installed to use `react-devtools`.
Yeah, devtools and ws have been moved as peerdependencies. We may also add it as devdependency so the warning is not visible in demo or we can hide/remove the warning since even you yourself tripped over the fact this warning is visible only when NODE_ENV is not set to "production" ;)
Anyway, v0.3.0 is live on npm :)
Final package size reduced from
to