Yomguithereal / react-blessed

A react renderer for blessed.
MIT License
4.45k stars 177 forks source link

Update to latest version of react-reconciler #83

Open wearhere opened 5 years ago

wearhere commented 5 years ago

Even though the README says that this library will work with React's latest v16.x.x, it does not seem that we can use the new lifecycles and context APIs introduced in React v16.3. For example:

I think this is because this library is using an outdated version of react-reconciler. That's where the latter invariant violation originates, and if I look up that invariant in the latest version of react-reconciler, there is logic about the new context API that does not exist in the version used by this library.

Yomguithereal commented 5 years ago

You are right. Unfortunately I don’t have much time right now. I will of course review and probably accept a PR fixing this issue :)