Updated dependecies, added useEffect support

Yomguithereal / react-blessed

A react renderer for blessed.

MIT License

4.45k stars 177 forks source link

Updated dependecies, added useEffect support #95

Closed tomaskallup closed 5 years ago

tomaskallup commented 5 years ago

I made some small changes, mainly updating dependecies, making sure hooks work on the stable react version. Also I tried my best to implement passive effects (useEffect), they seem to work now, but it's hard to tell if I did it right considering the documentation around react-reconciler. I believe this should finally fix #88, altough there are still some untested hooks:

useCallback
useMemo
useRef
useImperativeHandle
useLayoutEffect (this one might need some actual reconciler implementation)
useDebugValue

Yomguithereal commented 5 years ago

Hello @tomaskallup. Thanks for your PR. Can I ask you whether you think there is anything breaking in your addenda?

tomaskallup commented 5 years ago

Hi @Yomguithereal, there shouldn't be anything breaking. We already had hooks working - those are now updated to stable react version - and effect were never working.

Yomguithereal commented 5 years ago

Would you release a v0.6.0 or a v0.5.1?

tomaskallup commented 5 years ago

I would say v0.6.0, as this introduces some new features and it's backwards-compatible.

Yomguithereal commented 5 years ago

Done. v0.6.0 is now live on npm.

Yomguithereal commented 5 years ago

as this introduces some new features and it's backwards-compatible.

I think I remember however that versions < 1.0.0 are a bit quirky in npm as minors are considered majors when automatically bumping version at install time.

tomaskallup commented 5 years ago

https://semver.org/#spec-item-4 It says that anything can break at any point for the major < 1 version. But there is also this:

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.