search

Yomguithereal / react-blessed

A react renderer for blessed.
MIT License
4.45k stars 177 forks source link

Library prints devtools error message to console #99

Open wearhere opened 5 years ago

wearhere commented 5 years ago

If this library is loaded without react-devtools-core or ws being installed, https://github.com/Yomguithereal/react-blessed/blob/1ae620a62c90bd34051d6458876a6b70abd7cf77/src/fiber/devtools.js will throw an error, resulting in this message being logged to the console. I see that I can suppress that by setting NODE_ENV = 'production' prior to loading this library. Is that your recommendation for clients? I don't see anything in the README about that, would be nice to add.

Alternatively, it might be nice to only log this message at all for developers of react-blessed, e.g. compile that warning out, maybe not even try to require('./devtools'), when you build react-blessed for distribution.

If you intend for clients (not just yourselves) to be able to use the devtools, then it would be nice to document that in the README, and IMO make clients have to opt-into using react-devtools / seeing that warning, rather than, at present, have to set NODE_ENV to suppress the warning.

Yomguithereal commented 5 years ago

Hello @wearhere. You are making a good point. I guess clients should be able to use devtools but I agree those warnings should not pop out and devtool integration should really be opt-in. However, I don't remember if, at the time, some technical limit was not involved here. @iamdustan do you remember anything about this?