search

YomikoR / GetFnative

A script that help find the native fractional resolution of upscaled material (mostly anime)
GNU Lesser General Public License v2.1
14 stars 3 forks source link

descale_crop_args: Typing, `base_width` optional #1

Closed LightArrowsEXE closed 1 year ago

LightArrowsEXE commented 1 year ago

This makes it in-line with older versions, as well as match the supposed usage example.

This adds vstools as a dependency, but that should not be an issue considering I plan on opening more PRs in the future with packages that already depend on it anyway.

YomikoR commented 1 year ago

Thanks for the PR, but base_width should not be optional. Otherwise users may easily make mistakes by using an unintended parity of it.

LightArrowsEXE commented 1 year ago

Gotcha. I'd absolutely update the README too in that case, as the example shown there does not reflect the current implementation.