Yonaba / Jumper

Fast, lightweight and easy-to-use pathfinding library for grid-based games
http://yonaba.github.io/Jumper
MIT License
611 stars 123 forks source link

Syntax error #8

Closed Ziao closed 11 years ago

Ziao commented 11 years ago

Something minor, and I don't have time to fork and fix it myself at the moment:

https://github.com/Yonaba/Jumper/blob/master/jumper/core/floodfill.lua#L75 You open a '(' for the while statement but forget to close it before 'do'

Also, thanks a lot for this massively useful library ;)

Yonaba commented 11 years ago

Hi Ziao, First of all, thanks for your interest, and for the report. Technically, yes, it was a syntax error. But actually I wasn't planning to use or include that floodfill module. Actually, that was an experiment I was doing (see here for more details), and I didn't find it satisfying enough to be merged to this pathfinding project. So I am just removing this (unused) file.

Thanks, Roland.

Ziao commented 11 years ago

Yeah, I thought something along those lines, since I didn't see it used. However, when building an iOS app using Corona, it fails because of this error. Thanks :)

Yonaba commented 11 years ago

I'd also like to point out that you should use a stable version of this library, for the safety of your current project. From what I can see, it seems you are using the latest cutting edge version (which might be buggy, as it has lots of pending-and-not-fully-implemented-features-and-breaking-changes). I'd recommend the latest stable, for instance (see the relevant section in the Readme.