YongbinWang / pe

0 stars 0 forks source link

Remove file name command is not case insensitive #6

Open YongbinWang opened 1 year ago

YongbinWang commented 1 year ago

Describe the bug

When you try to remove the name of a file with some letters being capital case, it fails. There is no duplicate checking regarding the upper/lower case of a file.

To Reproduce

Steps to reproduce the behavior:

  1. make sure you added test2 inside the list
  2. remove n/TEST2

Expected

Expected command to be successful and actual test2 inside list to be removed. Users will appreciate this convenience. Even the operating system platform identifies TEST2 being the same as test2, see screenshot below.

Actual

Exception thrown and it is deemed as a different file.

Screenshots

image.png

image.png

nus-pe-script commented 1 year ago

Team's Response

This is the expected behavior but we did not mention this in the UG. Therefore we feel that this should be a documentation bug. We feel that the severity should be low as this only causes minor inconveniences because this behavior only happens when you use a different case letter from the file name you added.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: I believe this is definitely not a DocumentationBug, but a FeatureFlaw instead. This is suboptimal design on the developer's part where they did not check how the operating system checks for duplicate files names, therefore they did not consider handling duplicate checking which is quite an important function to have especially for filetypes and filenames. Referencing the issue id #10 where the team rebutted the validity of the file name, citing that they are following the operating system filename naming convention which does not seem to be the case here, showing the inconsistency.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]