add() -> push() - Githubissues

YongseopKim / ONE-vscode

Visual Studio Code Extension of ONE compiler toolchain

Apache License 2.0

0 stars 0 forks source link

add() -> push() #10

Closed YongseopKim closed 2 years ago

YongseopKim commented 2 years ago

How about throwing an error when value is undefined to decrease possible coding error?

That's good idea. I'll fix the add() after this PR.

the name add seems ambiguous -> push seems better while push is there on Array
- I need to check whether ts supports overloading.
So I would change add(string, string|undefined) -> push(string, ...) (internally handles by for-loop)

YongseopKim commented 2 years ago

draft 에서 테스트 후 적용하기
- © Githubissues.
- Githubissues is a development platform for aggregating issues.