search

Yoooi0 / MultiFunPlayer

flexible application to synchronize various devices with media playback
https://yoooi0.github.io/MultiFunPlayer/
MIT License
105 stars 20 forks source link

Add ability to change between http and https endpoints #150

Closed axw-pub closed 6 months ago

axw-pub commented 7 months ago

Describe the bug Script repositories are hard coded to http and don't support https calls on port 443.

To Reproduce Steps to reproduce the behavior:

  1. configure a stash or xbvr repository with ip or hostname and port 443
Yoooi0 commented 7 months ago

I dont think #151 is a correct fix as it hardcodes 443 as https port. The EndPointBox should be converted to UriBox or something like that with ability to specify the scheme and path. I'll try to implement it today but I have to also release 1.28/1.27.1

axw-pub commented 7 months ago

Yes, it only solves the most common case. Adding a protocol drop down to the settings UI will be better, of course. I can use port 80 with a 301 redirect for now, which works fine.

Yoooi0 commented 7 months ago

Pushed, UriBox probably needs some styling improvements tho. Let me know if find any issues.