Yooooomi / your_spotify

Self hosted Spotify tracking dashboard
GNU General Public License v3.0
2.67k stars 109 forks source link

design: Remove header background #349

Closed quentinguidee closed 4 months ago

quentinguidee commented 4 months ago

Since design changes can be controversial I'm very open to 'request changes', and you can close it if you don't like it

Before

image

After

image
RomainNeup commented 4 months ago

Hello @quentinguidee, could you take the opportunity to change the cog icon on top right with a calendar? A cog suggest a setting or something and it's not.

quentinguidee commented 4 months ago

Hello @quentinguidee, could you take the opportunity to change the cog icon on top right with a calendar? A cog suggest a setting or something and it's not.

I'm not sure of the render, because a calendar icon doesn't tell the user that this is a clickable icon

image
Yooooomi commented 4 months ago

I like it! Not sure about the calendar icon though haha.

quentinguidee commented 4 months ago

Should be fixed

Yooooomi commented 4 months ago

Merged and tested, it's good well done. I merged all the requests for this release so I'm gonna merge to master soon to create release builds. If you have anything blocking the release tell me :)

quentinguidee commented 4 months ago

I get migration issue when going to the release branch, should I change something manually in the database?

image
Yooooomi commented 4 months ago

This is weird, it feels like the migration file was not compiled / does not exist. I've not gone through this error. I don't know what to tell you actually.

quentinguidee commented 4 months ago

Then that's probably an issue caused by my attempt to fix the migration yesterday, that should not impact users.

Yooooomi commented 4 months ago

Yeah the file is not named like this haha, it's named 1708973485301-add_metadata_to_infos

quentinguidee commented 4 months ago

I edited it manually in mongo and it's fixed yep! Ty