search

Yooooomi / your_spotify

Self hosted Spotify tracking dashboard
GNU General Public License v3.0
2.64k stars 108 forks source link

[Feature Request] Return version without login #359

Closed bloedboemmel closed 3 months ago

bloedboemmel commented 4 months ago

Just a very small tweak, but it would help a lot monitoring my projects with Argus

Would it be possible to return the version, when using the GET /version from the API https://github.com/Yooooomi/your_spotify/blob/bba31e0debe90ac9fc86dfe45490fa7b1169647d/apps/server/src/routes/index.ts#L194

Or do you consider it a security risk?

Yooooomi commented 4 months ago

Do you know any other project that allows fetching the version using GET for your monitoring? How do you do usually to connect these projects to your Argus thing?

bloedboemmel commented 4 months ago

Bitwarden gives you the version without a login at admin/home/getinstalledwebversion and Audiobookshelf sends it in the html without login, you just need to regex it.

It would also help just to put it in the headers of the login html

quentinguidee commented 4 months ago

Immich seems to provide this too https://immich.app/docs/api/get-server-version

Yooooomi commented 4 months ago

I'll definitely fix this next release then