search

Yooooomi / your_spotify

Self hosted Spotify tracking dashboard
GNU General Public License v3.0
3.01k stars 122 forks source link

feat: rework sider design #360

Closed quentinguidee closed 6 months ago

quentinguidee commented 7 months ago

Some design refinements for the drawer

Before After
image image
Before After
image image
Yooooomi commented 7 months ago

Dude you got no chill haha. It seems cool. Is light mode working as intended? Is responsive still ok?

quentinguidee commented 7 months ago

Here are screenshots for dark mode:

image image

And responsive seems to work fine!

maaaathis commented 7 months ago

It looks really good 👍 The only thing I've never fully understood is the state of the current page. The red text differs greatly from the hover state. But idk.

Yooooomi commented 7 months ago

I guess we can just have the hover state persist when on the page

maaaathis commented 7 months ago

I guess we can just have the hover state persist when on the page

A bit darker or lighter, but yes.

Yooooomi commented 7 months ago

Lighter on dark mode, darker on light mode

quentinguidee commented 7 months ago

This way?

https://github.com/Yooooomi/your_spotify/assets/12123721/047f9b42-642f-4aa3-9261-2993871dc0da

Yooooomi commented 7 months ago

Maybe full white written in black when focused

maaaathis commented 7 months ago

Maybe full white written in black when focused

Thats the same too big contrast as on the search before.