Add switching sort key between count and total

Yooooomi / your_spotify

Self hosted Spotify tracking dashboard

GNU General Public License v3.0

2.64k stars 108 forks source link

Add switching sort key between count and total #395

Closed Blackcheckgamer closed 1 month ago

Blackcheckgamer commented 2 months ago

Hello There! I added the ability to change the sorting on the Tops by clicking on the corresponding header.

Sadly i am currently stuck on giving the user a hint, what the current sorting key is (see Top Songs). The hint only appears after switching to another site and back.

I would really appreciate any suggestions, not only to fix that specific problem but the changes overall, since I've never used React before.

Thanky You!

Yooooomi commented 1 month ago

I feel like such a setting should not be defined from a header. Maybe something in the settings, so that it appears more permanent if it's clear enough. I'll finish what you started, thanks a lot!

Yooooomi commented 1 month ago

After seeing your work, I remember this feature used to exist, but was discontinued when I switched from javascript to typescript. I moved the selection to the settings panel, and the past work should still work.