search

Yortw / tweetmoasharp

TweetSharp is a fast, clean wrapper around the Twitter API.
Other
72 stars 22 forks source link

AddListMemberAsync Long response time and request sometimes aborted #81

Open AsianPotato opened 4 years ago

AsianPotato commented 4 years ago

When the request gets aborted it crashes my app despite AddListMemberAsync being in a try catch. We make many other concurrent requests to other endpoints without issue.

Yortw commented 4 years ago

Hi,

Not sure why this method would be different to any others. I've done some tests with my test account, and it neither takes very long nor crashes for me. Do you have a specific list id and profile name that can be used to repro? Or a demo project that reproduces the issue?

Do you have any details or the error? An exception type, error message and/or stack trace?

AsianPotato commented 4 years ago

The list has 90 members, we request list members concurrently 24/7 with the same service object (without going over rate limit) , I've switched to .net core and linq2twitter and the issue is gone. Another thing I noticed is that the async methods seem to write to console https://github.com/Yortw/hammock/blob/13a575dac7775a048c16ef0d45cda1d564d1e9cc/src/net35/Hammock/Web/WebQuery.Async.cs on line 345

The exception was just that the request was aborted, I didn't really bother looking into it too much as the function was rarely used but the issue also did happen with the non async method.

Edit: I also use hammock with the console output on line 345 removed, surely that and compiling it myself didn't cause the issue?

Yortw commented 4 years ago

Thanks. I'll remove the console write, not sure how to test the list issue as I don't have 90 test accounst to add to a list and I don't particularly want to bother random users/my followers by using them.

I very much doubt your removing that line/recompiling Hammock would have caused the issue. I would have hoped the exception when thrown from the sync method was 'catchable' though?