search

YosefLab / Cassiopeia

A Package for Cas9-Enabled Single Cell Lineage Tracing Tree Reconstruction
https://cassiopeia-lineage.readthedocs.io/en/latest/
MIT License
77 stars 24 forks source link

CassiopeiaTree character matrix has inconsistencies in the naming conventions #112

Closed richardyz98 closed 3 years ago

richardyz98 commented 3 years ago

106

In the CassiopeiaTree, the character matrix attribute is called by self._character_matrix in some methods and in other methods called by self.character_matrix.

Sorry I didn't catch this earlier!

mattjones315 commented 3 years ago

Hi @richardyz98 -- this is actually intentional. The self._character_matrix is a hidden variable that stores the default character matrix. self.character_matrix is the property character matrix that can be set, copied, and manipulated.

Is there another problem with this?

EDIT (7/26/21 @ 5:16PM PT): This issue was not a bug but rather a small misunderstanding about the code and the use of setters on Python class properties.