codecov[bot]
commented
3 years ago Codecov Report
Merging #132 (56d53cc) into master (6336857) will increase coverage by
0.81%. The diff coverage is82.35%.
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 85.31% 86.12% +0.81%
==========================================
Files 65 65
Lines 4527 4525 -2
==========================================
+ Hits 3862 3897 +35
+ Misses 665 628 -37 | Impacted Files | Coverage Δ | |
|---|---|---|
| cassiopeia/solver/CassiopeiaSolver.py | 88.88% <ø> (ø) |
|
| cassiopeia/solver/GreedySolver.py | 98.57% <ø> (ø) |
|
| cassiopeia/solver/MaxCutGreedySolver.py | 93.47% <ø> (ø) |
|
| cassiopeia/solver/MaxCutSolver.py | 100.00% <ø> (ø) |
|
| cassiopeia/solver/NeighborJoiningSolver.py | 73.61% <0.00%> (ø) |
|
| cassiopeia/solver/SpectralGreedySolver.py | 95.83% <ø> (ø) |
|
| cassiopeia/solver/SpectralSolver.py | 100.00% <ø> (ø) |
|
| cassiopeia/solver/ILPSolver.py | 44.76% <86.66%> (+16.93%) |
:arrow_up: |
| cassiopeia/solver/DistanceSolver.py | 93.10% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6336857...56d53cc. Read the comment docs.
Here is a PR to fix 2 issues in the ILP post-processing and test:
1) We now remove spurious roots first before we prune edges, as previously if we prune edges first we may leave a sample only attached to a spurious root, thus deleting the leaf from the final tree 2) Fixed a bug in the way that we were removing spurious (non-sample) leaves from the final tree after appending samples, as before we were unintentionally not removing some of these leaves due to not handling an edge case when 2 spurious leaves are sisters
Closes #131