Closed sprillo closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -0.01
:warning:
Comparison is base (
e7606af
) 79.05% compared to head (653e2b1
) 79.05%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
A CassiopeiaTree is a complex nested object and should always be deepcopied, not shallow copied. In robinson_founds and triplets_correct, shallow copies of the input trees are being created before collapsing unifurcations, which as a result modifies the input trees:
https://github.com/YosefLab/Cassiopeia/blame/master/cassiopeia/critique/compare.py#L56-L61
Example:
Output:
Expected output:
Bug seems to have been introduced 2 years ago during a refactor of the critique module:
https://github.com/YosefLab/Cassiopeia/commit/27d165379ae5ac904891affb0e78fe6840e428c3