YosefLab / Cassiopeia

A Package for Cas9-Enabled Single Cell Lineage Tracing Tree Reconstruction
https://cassiopeia-lineage.readthedocs.io/en/latest/
MIT License
75 stars 24 forks source link

Fixed ILP cython error caused by pandas update #207

Closed colganwi closed 1 year ago

colganwi commented 1 year ago

With pandas=2.0.2 the character matrix passed by ILPSolver to ilp_solver_utilities.infer_potential_graph_cython is not correctly formatted for cython. This patch fixes this bug.

===================================================== ERROR: test_simple_potential_graph_inference (main.TestILPSolver)

Traceback (most recent call last): File "test/solver_tests/ilp_solver_test.py", line 119, in test_simple_potential_graph_inference potential_graph = self.ilp_solver.infer_potential_graph( File "/home/wcolgan/miniconda3/envs/tree-env/lib/python3.8/site-packages/cassiopeia/solver/ILPSolver.py", line 307, in infer_potential_graph ilp_solver_utilities.infer_potential_graph_cython( File "cassiopeia/solver/ilp_solver_utilities.pyx", line 21, in cassiopeia.solver.ilp_solver_utilities.infer_potential_graph_cython character_array: str[:, :], ValueError: Does not understand character buffer dtype format string ('w')


codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (020101f) 79.05% compared to head (c1a224f) 79.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #207 +/- ## ======================================= Coverage 79.05% 79.05% ======================================= Files 85 85 Lines 7080 7080 ======================================= Hits 5597 5597 Misses 1483 1483 ``` | [Files Changed](https://app.codecov.io/gh/YosefLab/Cassiopeia/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YosefLab) | Coverage Δ | | |---|---|---| | [cassiopeia/solver/ILPSolver.py](https://app.codecov.io/gh/YosefLab/Cassiopeia/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YosefLab#diff-Y2Fzc2lvcGVpYS9zb2x2ZXIvSUxQU29sdmVyLnB5) | `44.60% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.