search

YosefLab / Cassiopeia

A Package for Cas9-Enabled Single Cell Lineage Tracing Tree Reconstruction
https://cassiopeia-lineage.readthedocs.io/en/latest/
MIT License
77 stars 24 forks source link

[Ready for Review] Add UniformLeafSubsampler and moved collapsing mutationless edges into CassiopeiaTree #83

Closed richardyz98 closed 3 years ago

richardyz98 commented 3 years ago

Hi all, This is just a small PR moving collapsing mutationless edges into the CassiopeiaTree.

Also this brings up the question: in get_mutations_on_edge, should we report mutations from a non-0 character to the missing state. The current implementation does not show these. If so, I'll use get_mutations_on_edge in the implementation of collapse_mutationless_edges, otherwise I'll continue to match the character vectors.

Thanks in advance! Richard